[chore:] logging for ResultWindow.axaml.cs

DataStore/DataStructures.cs

@@ -60,6 +60,11 @@ public class KasAddressList //Address-Set
         var id = listItemName.Split(" - ")[0];
         return int.Parse(id);
     }
+
+    public override string ToString()
+    {
+        return Name + " (" + KasPersons.Count + " Einträge)";
+    }
 }
 
 public class KasPerson
@@ -188,6 +193,18 @@ public class KasPerson
 
         return highest + base_id + 1;
     }
+
+    public override string ToString()
+    {
+        if (refsid != null && refsid != 0)
+        {
+            return refsid + " - " + name;
+        }
+        else
+        {
+            return id + " - " + name;
+        }
+    }
 }
 
 public class KasPersonError
@@ -212,4 +229,9 @@ public class KasPersonError
 
         return output;
     }
+
+    public string ToString(KasPerson person)
+    {
+        return "ID:"+person.id + "; Name: " +person.name +"; Errors: " + GetString();
+    }
 }

DataStore/Settings.cs

@@ -45,9 +45,8 @@ public class Settings
         }
         catch (Exception ex)
         {
-            Console.WriteLine(ex.Message);
+            Logger.Log($"Error while reading settings. Generating new... {ex.Message}", Logger.LogType.Warning);
-            Console.WriteLine(ex.StackTrace);
+
-            Console.WriteLine("Error while reading settings. Generating new...");
             _instance = new Settings();
         }
     }
@@ -123,9 +122,7 @@ public class Global
         }
         catch (Exception ex)
         {
-            Console.WriteLine(ex.Message);
+            Logger.Log($"Error while reading global settings. Generating new... {ex.Message}", Logger.LogType.Warning);
-            Console.WriteLine(ex.StackTrace);
-            Console.WriteLine("Error while reading global settings. Generating new...");
             _instance = new Global();
             Save();
         }
@@ -135,7 +132,7 @@ public class Global
 public class Customers
 {
     public List<Customer> customers = new();
-    public int current { get; set; } = 0;
+    public Customer current { get; set; } = null;
 }
 
 public class Customer
@@ -150,6 +147,11 @@ public class Customer
         ID = highestID + 1;
     }
     
+    public override string ToString()
+    {
+        return name;
+    }
+
     public string name { get; set; } = "";
     public string description { get; set; } = "";
     public string sender_address { get; set; } = "";
@@ -158,11 +160,11 @@ public class Customer
     public int ID { get; }
 
 
-    public static int GetIDByCustomerListItem(string item_content)
+    // public static int GetIDByCustomerListItem(string item_content)
-    {
+    // {
-        var id = item_content.Split(" - ")[0];
+    //     var id = item_content.Split(" - ")[0];
-        return int.Parse(id);
+    //     return int.Parse(id);
-    }
+    // }
 }
 
 public class AddressSets

Logger.cs

@@ -0,0 +1,40 @@
+using System;
+using System.IO;
+using Newtonsoft.Json;
+
+namespace Logof_Client;
+
+public static class Logger
+{
+    public static void Log(string text, LogType logType = LogType.Info)
+    {
+        try
+        {
+            string config_path = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData),
+                "logofclient");
+            if (!Directory.Exists(config_path))
+                Directory.CreateDirectory(config_path);
+
+            string log_path = Path.Combine(config_path, $"log-{DateTime.Now:dd-MM-yy}.log");
+            if(!File.Exists(log_path))
+                File.Create(log_path).Close();
+
+            string line = $"[{DateTime.Now:dd.MM.yyyy - hh:mm:ss}]: ({logType.ToString()}) {text}";
+            Console.WriteLine(line);
+            
+            File.AppendAllLines(log_path, [line]);
+        }
+        catch (Exception ex)
+        {
+            Console.WriteLine(ex);
+        }
+        
+    }
+
+    public enum LogType
+    {
+        Error,
+        Warning,
+        Info
+    }
+}

MainWindow.axaml

@@ -121,7 +121,7 @@
                                                FontWeight="Bold" />
                                     </StackPanel>
                                 </Button>
-                                <Button Width="250" IsEnabled="False"
+                                <Button Width="250" IsEnabled="False" Click="BtnShorten_OnClick"
                                         HorizontalContentAlignment="Center" x:Name="BtnShorten"
                                         Margin="0,0,0,10">
                                     <StackPanel Orientation="Horizontal">
@@ -220,14 +220,18 @@
                                             </StackPanel>
                                             <Label FontSize="9" Content="Nur Elemente, die NICHT doppelt sind" />
                                         </StackPanel>
-
                                     </Button>
                                 </StackPanel>
-                                <StackPanel Orientation="Vertical" HorizontalAlignment="Center">
+                                <StackPanel Orientation="Horizontal" HorizontalAlignment="Center" Spacing="50">
+                                    <StackPanel Orientation="Vertical" >
                                         <RadioButton Content="Vergleiche nach refsid" IsChecked="True" x:Name="RbComprefsid"></RadioButton>
                                         <RadioButton Content="Vergleiche nach finaler Adresse" IsChecked="False" x:Name="RbCompfinAd"></RadioButton>
                                     </StackPanel>
-                                <CheckBox HorizontalAlignment="Center" x:Name="CbMergeExportUnmerged" IsChecked="False">Speichere Unverarbeitete in neuem Verteiler</CheckBox>
+                                    <StackPanel Orientation="Vertical">
+                                        <CheckBox HorizontalAlignment="Left" x:Name="CbMergeExportUnmerged" IsChecked="False">Speichere Unverarbeitete in neuem Verteiler</CheckBox>
+                                        <CheckBox HorizontalAlignment="Left" x:Name="CbMergeDeleteOld" IsChecked="False">Lösche ursprüngliche Sets</CheckBox>
+                                    </StackPanel>
+                                </StackPanel>
                             </StackPanel>
                         </Grid>
                         <Grid Grid.Row="2" Margin="20" ColumnDefinitions="*,5*,*" IsVisible="False" x:Name="GrdExportMarginOptions">
@@ -481,12 +485,20 @@
                                                  TextChanged="TbSettingsCustomerSenderAddress_OnTextChanged"
                                                  x:Name="TbSettingsCustomerSenderAddress" />
                                     </Grid>
-                                    <Grid ColumnDefinitions="150,*">
+                                    <Grid ColumnDefinitions="150,*,Auto">
                                         <Label Content="CSV-Trennzeichen" />
                                         <TextBox Grid.Column="1" Watermark=","
-                                                 HorizontalAlignment="Stretch"
+                                                 HorizontalAlignment="Stretch" Margin="0,0,5,0"
                                                  TextChanged="TbSettingsCustomerCsvSeparator_OnTextChanged"
                                                  x:Name="TbSettingsCustomerCsvSeparator" />
+                                        <StackPanel Grid.Column="2" Orientation="Horizontal" Spacing="5">
+                                            <Button Click="ChangeCSVDivider" Content=","></Button>
+                                            <Button Click="ChangeCSVDivider" Content=";"></Button>
+                                            <Button Click="ChangeCSVDivider" Content="TAB"></Button>
+                                            <Button Click="ChangeCSVDivider" Content="|"></Button>
+                                            <Button Click="ChangeCSVDivider" Content="SPACE"></Button>
+                                            <Button Click="ChangeCSVDivider" Content=":"></Button>
+                                        </StackPanel>
                                     </Grid>
                                     <Grid ColumnDefinitions="150,*">
                                         <Label Content="Address-Patch-Info" />

MainWindow.axaml.cs

@@ -24,6 +24,9 @@ public partial class MainWindow : Window
 
     public MainWindow()
     {
+        Logger.Log("Welcome to logofclient");
+        Logger.Log($"Session on {DateTime.Now:G}");
+        Logger.Log("Initializing...");
         InitializeComponent();
         //Hide();
         
@@ -32,6 +35,7 @@ public partial class MainWindow : Window
 
         _instance = this;
         WindowState = WindowState.Maximized;
+        Logger.Log("Loading settings...");
         Global.Load();
         Settings.Load();
         LoadPdfExportOptions();
@@ -40,6 +44,7 @@ public partial class MainWindow : Window
         RefreshCountryView();
 
         // Initialize wiki integration
+        Logger.Log("Building wiki...");
         _wikiService = new WikiService();
         try
         {
@@ -54,8 +59,9 @@ public partial class MainWindow : Window
                 if (!string.IsNullOrWhiteSpace(Global._instance.wiki_storage_path))
                     TbWikiPath.Text = Global._instance.wiki_storage_path;
             }
-            catch
+            catch (Exception ex)
             {
+                Logger.Log($"Error while setting paths: {ex.Message}", Logger.LogType.Error);
             }
 
             try
@@ -64,12 +70,14 @@ public partial class MainWindow : Window
                 BtnFontPath.Click += BtnFontPath_Click;
                 BtnConfigPath.Click += BtnConfigPath_Click;
             }
-            catch
+            catch (Exception ex)
             {
+                Logger.Log($"Error while adding click functions?: {ex.Message}", Logger.LogType.Error);
             }
         }
-        catch
+        catch (Exception ex)
         {
+            Logger.Log($"Error while doing wiki stuff: {ex.Message}", Logger.LogType.Error);
         }
 
         //Thread.Sleep(3000);
@@ -96,28 +104,32 @@ public partial class MainWindow : Window
 
         new ResultWindow(result, addresSetID).Show();
 
+        Settings.Save();
         
         //await MessageBox.Show(_instance, $"{result.Count} Einträge fehlerhaft.", "Fertig");
     }
     
-    // private async void StartAddressRepair(Uri path)
+    private async void StartAddressShortener(KasAddressList set)
-    // {
+    {
         //var addresses = DataImport.ImportKasAddressList(path); // Ihr Code hier
-    //     var progressWindow = new ProgressWindow();
+
-    //
+        var progressWindow = new ProgressWindow();
-    //     progressWindow.Show(_instance);
+
-    //
+        progressWindow.Show(_instance);
-    //     var processor = new AddressRepair(progressWindow);
+
-    //     //var result = await processor.Perform(addresses.Item2, errors);
+        var processor = new AddressShortener(progressWindow);
-    //
+        await processor.Perform(set);
-    //
+
-    //     progressWindow.Close();
+        // foreach (var item in result)
-    //
+        // {
-    //
-    //     //new ResultWindow(result, addresses.Item2).Show();
-    //     //await MessageBox.Show(_instance, $"{result.Count} Einträge fehlerhaft.", "Fertig");
         // }
 
+        progressWindow.Close();
+        Settings.Save();
+        //await MessageBox.Show(_instance, $"{result.Count} Einträge fehlerhaft.", "Fertig");
+    }
+    
+
     private void MnuExit_OnClick(object? sender, RoutedEventArgs e)
     {
         Environment.Exit(0);
@@ -135,7 +147,7 @@ public partial class MainWindow : Window
         }
         catch (Exception ex)
         {
-            Console.WriteLine($"Fehler beim Öffnen des Links: {ex.Message}");
+            Logger.Log($"Error while starting process: {ex.Message}", Logger.LogType.Error);
         }
     }
 
@@ -151,7 +163,7 @@ public partial class MainWindow : Window
         }
         catch (Exception ex)
         {
-            Console.WriteLine($"Fehler beim Öffnen des Links: {ex.Message}");
+            Logger.Log($"Error while starting process: {ex.Message}", Logger.LogType.Error);
         }
     }
 
@@ -167,31 +179,10 @@ public partial class MainWindow : Window
         }
         catch (Exception ex)
         {
-            Console.WriteLine($"Fehler beim Öffnen des Links: {ex.Message}");
+            Logger.Log($"Error while starting process: {ex.Message}", Logger.LogType.Error);
         }
     }
 
-    private async void BtnChooseFile_OnClick(object? sender, RoutedEventArgs e)
-    {
-        var topLevel = GetTopLevel(this);
-        var file = await topLevel!.StorageProvider.OpenFilePickerAsync(new FilePickerOpenOptions
-        {
-            Title = "KAS-CSV-Datei auswählen",
-            AllowMultiple = false,
-            FileTypeFilter = new[]
-            {
-                new FilePickerFileType(".csv-Datei")
-                {
-                    Patterns = new[] { "*.csv" }
-                }
-            }
-        });
-
-        if (file == null) return;
-        //TbFilename.Text = file[0].Path.ToString();
-        filePath = file[0].Path;
-    }
-
     private void BtnCheck_OnClick(object? sender, RoutedEventArgs e)
     {
         MakeCalcManVisible();
@@ -201,7 +192,7 @@ public partial class MainWindow : Window
             return;
         }
 
-        StartAddressCheck(KasAddressList.GetIDByAddressSetListItem(LstCustomerAdressSets.SelectedItem.ToString()));
+        StartAddressCheck(((KasAddressList)LstCustomerAdressSets.SelectedItem).ID);
     }
 
     private void BtnCombine_OnClick(object? sender, RoutedEventArgs e)
@@ -218,41 +209,7 @@ public partial class MainWindow : Window
         GrdExportMarginOptions.IsVisible = false;
     }
 
-    private async void StartCombine(Uri path)
-    {
-        MakeCalcManVisible();
-        var addresses = await DataImport.ImportKasAddressList(path);
-        var progressWindow = new ProgressWindow();
-        var address_list = new List<KasAddressList> { addresses.Item2 };
     
-        var topLevel = GetTopLevel(this);
-        var file = await topLevel!.StorageProvider.OpenFilePickerAsync(new FilePickerOpenOptions
-        {
-            Title = "Weitere KAS-CSV-Dateien auswählen",
-            AllowMultiple = true,
-            FileTypeFilter = new[]
-            {
-                new FilePickerFileType(".csv-Dateien")
-                {
-                    Patterns = new[] { "*.csv" }
-                    //Patterns = new[] { "*" }
-                }
-            }
-        });
-
-        if (file == null) return;
-
-        //filePath = file[0].Path;
-        foreach (var f in file) address_list.Add((await DataImport.ImportKasAddressList(f.Path)).Item2);
-
-        progressWindow.Show(_instance);
-
-        var processor = new CombineAddresses(progressWindow);
-        //var result = await processor.Perform(address_list);
-
-
-        progressWindow.Close();
-    }
 
     private async void NavTree_SelectionChanged(object? sender, SelectionChangedEventArgs e)
     {
@@ -266,9 +223,9 @@ public partial class MainWindow : Window
                 var rendered = MarkdownRenderer.Render(text ?? string.Empty);
                 PreviewPanel.Children.Add(rendered);
             }
-            catch
+            catch (Exception ex)
             {
-                // fallback: plain text
+                Logger.Log($"Error while rendering markdown: {ex.Message}", Logger.LogType.Error);
                 PreviewPanel.Children.Clear();
                 PreviewPanel.Children.Add(new TextBlock { Text = text ?? string.Empty });
             }
@@ -283,6 +240,8 @@ public partial class MainWindow : Window
     }
 
     public void PopulateNavTree(string? expandToPath = null, string? selectPath = null)
+    {
+        try
         {
             var roots = _wikiService.GetRootItems();
             var nodes = new List<TreeViewItem>();
@@ -296,6 +255,10 @@ public partial class MainWindow : Window
                 ExpandAndFindNode(nodes, selectPath, out var selectedNode) &&
                 selectedNode != null)
                 NavTree.SelectedItem = selectedNode;
+        }catch (Exception ex)
+        {
+            Logger.Log($"Error while populating nav tree: {ex.Message}", Logger.LogType.Error);
+        }
     }
 
     private TreeViewItem BuildNode(WikiItem item)
@@ -309,6 +272,8 @@ public partial class MainWindow : Window
     }
 
     private string GetSelectedWikiTargetDirectory()
+    {
+        try
         {
             var wikiRoot = Global._instance.wiki_storage_path;
             if (NavTree.SelectedItem is TreeViewItem treeItem && treeItem.Tag is WikiItem selectedItem)
@@ -318,8 +283,13 @@ public partial class MainWindow : Window
                 var parentDir = Path.GetDirectoryName(selectedItem.Path);
                 if (!string.IsNullOrWhiteSpace(parentDir)) return parentDir;
             } 
-
             return wikiRoot;
+        }catch (Exception ex)
+        {
+            Logger.Log($"Error while getting selected wiki target directory: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return null;
     }
 
     private static bool PathsEqual(string left, string right)
@@ -378,8 +348,9 @@ public partial class MainWindow : Window
                 UseShellExecute = true
             });
         }
-        catch
+        catch (Exception ex)
         {
+            Logger.Log($"Error while starting process: {ex.Message}", Logger.LogType.Error);
         }
     }
 
@@ -437,39 +408,7 @@ public partial class MainWindow : Window
         MessageBox.Show(this, "Bitte starten Sie das Programm neu, um die Änderungen wirksam zu machen.", "Achtung");
     }
 
-    private async Task<string> OpenSettingsSaveAsDialog()
-    {
-        var settingsFileName = "KAS-Adress-Liste";
     
-        try
-        {
-            var filePicker = new SaveFileDialog
-            {
-                Title = "Datei speichern...",
-                InitialFileName = $"{settingsFileName}.csv",
-                DefaultExtension = ".csv",
-                Filters = new List<FileDialogFilter>
-                {
-                    new() { Name = "CSV-Datei", Extensions = { "csv" } }
-                }
-            };
-
-            var settingsSavePath = await filePicker.ShowAsync(this);
-            if (settingsSavePath == null)
-            {
-            }
-
-            return settingsSavePath;
-            //SettingsManager.Save(settingsSavePath);
-            //Logger.Log("Settings saved at " + settingsSavePath);
-        }
-        catch (Exception ex)
-        {
-            //Logger.Log("Saving file not successful: " + ex.Message, Logger.LogType.Error);
-            await MessageBox.Show(this, ex.Message, "Fehler beim Speichern der Datei");
-            return null;
-        }
-    }
 
     private async void StartCombine(List<KasAddressList> address_lists, int owner_id, string type, CombineAddresses.CombineType comb_type)
     {
@@ -478,7 +417,7 @@ public partial class MainWindow : Window
         progressWindow.Show(_instance);
 
         var processor = new CombineAddresses(progressWindow);
-        var result = await processor.Perform(address_lists, type, comb_type, CbMergeExportUnmerged.IsChecked);
+        var result = await processor.Perform(address_lists, type, comb_type, CbMergeExportUnmerged.IsChecked, CbMergeDeleteOld.IsChecked);
 
         if (result.Item1 != null)
             result.Item1.owner_id = owner_id;
@@ -509,8 +448,9 @@ public partial class MainWindow : Window
         {
             LstSettingsCustomers.SelectedIndex = LstSettingsCustomers.Items.Count - 1;
         }
-        catch
+        catch (Exception ex)
         {
+            Logger.Log($"Error while setting selected item: {ex.Message}", Logger.LogType.Error);
         }
     }
 
@@ -518,7 +458,7 @@ public partial class MainWindow : Window
     {
         if (LstSettingsCustomers.SelectedIndex == null || LstSettingsCustomers.SelectedIndex == -1) return;
         foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Settings._instance.customers.current)
+            if (customer.ID == Settings._instance.customers.current.ID)
                 customer.name = TbSettingsCustomerName.Text;
         //Settings.Save();
         //RefreshCustomerItems();
@@ -528,19 +468,19 @@ public partial class MainWindow : Window
     {
         if (LstSettingsCustomers.SelectedIndex < 0) return;
         Settings._instance.customers.current =
-            Customer.GetIDByCustomerListItem(LstSettingsCustomers.SelectedItems[0].ToString());
+            ((Customer)LstSettingsCustomers.SelectedItems[0]);
-        foreach (var customer in Settings._instance.customers.customers)
+        //foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Settings._instance.customers.current)
+            //if (customer.ID == Settings._instance.customers.current.ID)
-            {
+            //{
-                TbSettingsCustomerDescription.Text = customer.description;
+                TbSettingsCustomerDescription.Text = Settings._instance.customers.current.description;
-                TbSettingsCustomerName.Text = customer.name;
+                TbSettingsCustomerName.Text = Settings._instance.customers.current.name;
-                TbSettingsCustomerSenderAddress.Text = customer.sender_address;
+                TbSettingsCustomerSenderAddress.Text = Settings._instance.customers.current.sender_address;
-                TbSettingsCustomerCsvSeparator.Text = customer.separator.ToString();
+                TbSettingsCustomerCsvSeparator.Text = Settings._instance.customers.current.separator.ToString();
-                if (customer.patch != null)
+                if (Settings._instance.customers.current.patch != null)
-                    TbSettingsCustomerPatchInfo.Text = customer.patch.ToString();
+                    TbSettingsCustomerPatchInfo.Text = Settings._instance.customers.current.patch.ToString();
                 else
                     TbSettingsCustomerPatchInfo.Text = "";
-            }
+            //}
     }
 
     private async void EditButton_Click(object? sender, RoutedEventArgs e)
@@ -573,25 +513,33 @@ public partial class MainWindow : Window
         LstSettingsCustomers.Items.Clear();
         foreach (var customer in Settings._instance.customers.customers)
         {
-            LstCustomers.Items.Add(customer.ID + " - " + customer.name);
+            LstCustomers.Items.Add(customer);
-            LstSettingsCustomers.Items.Add(customer.ID + " - " + customer.name);
+            LstSettingsCustomers.Items.Add(customer);
         }
 
         try
         {
             LstSettingsCustomers.SelectedIndex = index;
         }
-        catch
+        catch (Exception ex)
         {
+            Logger.Log($"Error while setting selected index: {ex.Message}", Logger.LogType.Error);
         }
     }
 
     private void TbSettingsCustomerDescription_OnTextChanged(object? sender, TextChangedEventArgs e)
+    {
+        try
         {
             if (LstSettingsCustomers.SelectedIndex == null || LstSettingsCustomers.SelectedIndex == -1) return;
                     foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Settings._instance.customers.current)
+                        if (customer.ID == Settings._instance.customers.current.ID)
                             customer.description = TbSettingsCustomerDescription.Text;
+        } catch (Exception ex)
+        {
+            Logger.Log($"Error while changing customer description: {ex.Message}", Logger.LogType.Error);
+        }
+        
         //Settings.Save();
     }
 
@@ -605,11 +553,13 @@ public partial class MainWindow : Window
     {
         MakeCalcManVisible();
         if (LstCustomers.SelectedItems == null || LstCustomers.SelectedIndex == -1) return;
-        var customer_id = int.Parse(LstCustomers.SelectedItem.ToString().Split(" - ")[0]);
+        var customer_id = ((Customer)LstCustomers.SelectedItem).ID;
         RefreshAddressSetListItems(customer_id);
     }
 
     private async void BtnCustomerAddressSetImport_OnClick(object? sender, RoutedEventArgs e)
+    {
+        try
         {
             MakeCalcManVisible();
              var opts = new FilePickerOpenOptions();
@@ -630,7 +580,7 @@ public partial class MainWindow : Window
              var selected_path = paths[0].Path;
      
              foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Customer.GetIDByCustomerListItem(LstCustomers.SelectedItems[0].ToString()))
+                 if (customer == ((Customer)LstCustomers.SelectedItems[0]))
                  {
                      if (customer.patch == null)
                      {
@@ -668,6 +618,13 @@ public partial class MainWindow : Window
      
      
              Settings.Save();
+            
+        }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while importing: {ex.Message}", Logger.LogType.Error);
+        }
+        
     }
 
     public void RefreshAddressSetListItems(int customer_id)
@@ -685,7 +642,7 @@ public partial class MainWindow : Window
         foreach (var k in Settings._instance.addressSets.addresses)
         foreach (var customer in Settings._instance.customers.customers)
             if (customer.ID == k.owner_id && customer.ID == customer_id)
-                LstCustomerAdressSets.Items.Add(k.ID + " - " + k.Name + " (" + k.KasPersons.Count + " Einträge)");
+                LstCustomerAdressSets.Items.Add(k);
     }
 
     private void LstCustomerAdressSets_OnSelectionChanged(object? sender, SelectionChangedEventArgs e)
@@ -704,6 +661,7 @@ public partial class MainWindow : Window
             BtnCheck.IsEnabled = true;
             BtnCombine.IsEnabled = true;
             BtnGenerateLabels.IsEnabled = true;
+            BtnShorten.IsEnabled = true;
 
             // BtnRepair.IsEnabled = true;
             // BtnShorten.IsEnabled = true;
@@ -711,6 +669,8 @@ public partial class MainWindow : Window
     }
 
     private async void BtnSettingsImportCustomerAddressPatch_OnClick(object? sender, RoutedEventArgs e)
+    {
+        try
         {
             if (LstSettingsCustomers.SelectedIndex == null || LstSettingsCustomers.SelectedIndex == -1) return;
             
@@ -732,11 +692,16 @@ public partial class MainWindow : Window
             var selected_path = paths[0].Path;
     
             foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Customer.GetIDByCustomerListItem(LstSettingsCustomers.SelectedItems[0].ToString()))
+                if (customer.ID == ((Customer)LstSettingsCustomers.SelectedItems[0]).ID)
                     customer.patch = AddressPatch.Import(selected_path);
     
     
             Settings.Save();
+        } catch (Exception ex)
+        {
+            Logger.Log($"Error while importing customer address patch: {ex.Message}", Logger.LogType.Error);
+        }
+        
     }
 
     private void TbSettingsCustomerCsvSeparator_OnTextChanged(object? sender, TextChangedEventArgs e)
@@ -746,7 +711,7 @@ public partial class MainWindow : Window
             ? TbSettingsCustomerCsvSeparator.Text
             : ",";
         foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Settings._instance.customers.current)
+            if (customer.ID == Settings._instance.customers.current.ID)
                 try
                 {
                     customer.separator = Convert.ToChar(sep);
@@ -754,26 +719,27 @@ public partial class MainWindow : Window
                 catch (FormatException ex)
                 {
                     MessageBox.Show(this, "Error while converting: " + ex.Message, "Could not parse");
+                    Logger.Log($"Error while converting: {ex.Message}", Logger.LogType.Error);
                 }
                 catch (Exception ex)
                 {
                     MessageBox.Show(this, "Unknown Error: " + ex.Message, "Error");
+                    Logger.Log($"Error while converting: {ex.Message}", Logger.LogType.Error);
                 }
+
     }
 
     private void BtnCombineDifference_OnClick(object? sender, RoutedEventArgs e)
     {
         var list = new List<KasAddressList>();
         foreach (var item in LstCustomerAdressSets.SelectedItems)
-            list.Add(Settings._instance.addressSets.GetAddressSetByID(
+            list.Add((KasAddressList)item);
-                Convert.ToInt32(item.ToString().Split(" - ")[0])));
         try
         {
-            StartCombine(list, Convert.ToInt32(LstCustomers.SelectedItem.ToString().Split(" - ")[0]), "difference", GetCombiningTyp());
+            StartCombine(list, Convert.ToInt32(LstCustomers.SelectedItem), "difference", GetCombiningTyp());
-        }
+        }catch (Exception ex)
-        catch
         {
-            
+            Logger.Log($"Error while combining (difference): {ex.Message}", Logger.LogType.Error);
         }
     }
 
@@ -781,15 +747,14 @@ public partial class MainWindow : Window
     {
         var list = new List<KasAddressList>();
         foreach (var item in LstCustomerAdressSets.SelectedItems)
-            list.Add(Settings._instance.addressSets.GetAddressSetByID(
+            list.Add((KasAddressList)item);
-                Convert.ToInt32(item.ToString().Split(" - ")[0])));
         try
         {
-            StartCombine(list, Convert.ToInt32(LstCustomers.SelectedItem.ToString().Split(" - ")[0]), "union", GetCombiningTyp());
+            StartCombine(list, Convert.ToInt32((LstCustomers.SelectedItem as Customer).ID), "union", GetCombiningTyp());
         }
-        catch
+        catch (Exception ex)
         {
-            
+            Logger.Log($"Error while combining (union): {ex.Message}", Logger.LogType.Error);
         }
         
     }
@@ -798,15 +763,14 @@ public partial class MainWindow : Window
     {
         var list = new List<KasAddressList>();
         foreach (var item in LstCustomerAdressSets.SelectedItems)
-            list.Add(Settings._instance.addressSets.GetAddressSetByID(
+            list.Add((KasAddressList)item);
-                Convert.ToInt32(item.ToString().Split(" - ")[0])));
         try
         {
             StartCombine(list, Convert.ToInt32(LstCustomers.SelectedItem.ToString().Split(" - ")[0]), "intersection", GetCombiningTyp());
         }
-        catch
+        catch (Exception ex)
         {
-                
+            Logger.Log($"Error while combining (intersection): {ex.Message}", Logger.LogType.Error);
         }
     }
 
@@ -827,8 +791,7 @@ public partial class MainWindow : Window
     {
         var list = new List<KasAddressList>();
         foreach (var item in LstCustomerAdressSets.SelectedItems)
-            list.Add(Settings._instance.addressSets.GetAddressSetByID(
+            list.Add((KasAddressList)item);
-                Convert.ToInt32(item.ToString().Split(" - ")[0])));
 
         StartCombine(list, Convert.ToInt32(LstCustomers.SelectedItem.ToString().Split(" - ")[0]), "symdiff", GetCombiningTyp());
     }
@@ -842,36 +805,72 @@ public partial class MainWindow : Window
     }
 
     private async void BtnStartGenerateLabels_OnClick(object? sender, RoutedEventArgs e)
+    {
+        try
         {
             SavePdfExportOptions();
 
             var saveDialog = new SaveFileDialog
             {
                 DefaultExtension = "pdf",
-            Filters = { new FileDialogFilter { Name = "PDF-Dateien", Extensions = { "pdf" } } }
+                Filters =
+                {
+                    new FileDialogFilter
+                    {
+                        Name = "PDF-Dateien",
+                        Extensions = { "pdf" }
+                    }
+                }
             };
+
             var filePath = await saveDialog.ShowAsync(this);
 
-        if (!string.IsNullOrEmpty(filePath))
+            Console.WriteLine($"RAW: {filePath}");
+
+            if (!string.IsNullOrWhiteSpace(filePath))
             {
+                if (filePath.StartsWith("file://"))
+                {
+                    filePath = new Uri(filePath).LocalPath;
+                }
+
+                Console.WriteLine($"PATH: {filePath}");
+
                 var builder = new PdfBuilder(Settings._instance.pdfExport);
 
                 builder.CreateAddressLabelPdfFromAddressSetWithPlaceholder(
-                Convert.ToInt32(LstCustomerAdressSets.SelectedItems[0].ToString().Split(" - ")[0]),
+                    ((KasAddressList)LstCustomerAdressSets.SelectedItem).ID,
                     "Company Logo/Info",
                     filePath
                 );
-            //return true;
+
+                Console.WriteLine("PDF OK");
+            }
+        }
+
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while generating labels: {ex.Message}", Logger.LogType.Error);
         }
     }
 
     private void HookPdfExportOptionEvents()
+    {
+        try
         {
             var controls = GetPdfExportControls();
             foreach (var control in controls) control.ValueChanged += PdfExportOption_OnValueChanged;
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while hooking pdf export margins: {ex.Message}", Logger.LogType.Error);
+        }
+
+    }
 
     private void LoadPdfExportOptions()
+    {
+        try
         {
             var options = Settings._instance.pdfExport ?? new PdfExportSettings();
 
@@ -890,6 +889,12 @@ public partial class MainWindow : Window
             NudExpMargFontSize.Value = (decimal)options.fontSize;
             NudExpMargSmallFontSize.Value = (decimal)options.smallFontSize;
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while loading PDF Export Options: {ex.Message}", Logger.LogType.Error);
+        }
+        
+    }
 
     private void SavePdfExportOptions()
     {
@@ -950,7 +955,7 @@ public partial class MainWindow : Window
     {
         if (LstSettingsCustomers.SelectedIndex == null || LstSettingsCustomers.SelectedIndex == -1) return;
         foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Settings._instance.customers.current)
+            if (customer.ID == Settings._instance.customers.current.ID)
                 customer.sender_address = TbSettingsCustomerSenderAddress.Text;
     }
 
@@ -969,6 +974,7 @@ public partial class MainWindow : Window
 
     public void RefreshCountryView()
     {
+        
         if (_suppressCountryRefresh) return;
         try
         {
@@ -983,8 +989,9 @@ public partial class MainWindow : Window
             {
                 CountryList.Items.Clear();
             }
-            catch
+            catch (Exception ex)
             {
+                Logger.Log($"Error while clearing country list: {ex.Message}", Logger.LogType.Error);
             }
 
             foreach (var c in Global._instance.countries) CountryList.Items.Add(c.name);
@@ -992,17 +999,19 @@ public partial class MainWindow : Window
             {
                 CountryList.SelectedIndex = country_index;
             }
-            catch
+            catch (Exception ex)
             {
+                Logger.Log($"Error while setting selected item: {ex.Message}", Logger.LogType.Error);
             }
 
             try
             {
                 _selectedCountry = Country.GetByName(CountryList.SelectedItems[0].ToString());
             }
-            catch
+            catch (Exception ex)
             {
                 _selectedCountry = null;
+                Logger.Log($"Error while getting country: {ex.Message}", Logger.LogType.Error);
             }
 
             if (_selectedCountry == null) return;
@@ -1016,8 +1025,9 @@ public partial class MainWindow : Window
             {
                 LbSettingsAlternatives.SelectedIndex = alt_index;
             }
-            catch
+            catch (Exception ex)
             {
+                Logger.Log($"Error while setting selected item: {ex.Message}", Logger.LogType.Error);
             }
         }
         finally
@@ -1033,9 +1043,9 @@ public partial class MainWindow : Window
             {
                 _selectedCountry.alternatives.Remove(selected.ToString());
             }
-            catch
+            catch (Exception ex)
             {
-                Console.WriteLine("Error while removing country alternative");
+                Logger.Log($"Error while removing alternatives: {ex.Message}", Logger.LogType.Error);
             }
 
         RefreshCountryView();
@@ -1110,6 +1120,7 @@ public partial class MainWindow : Window
         catch (Exception ex)
         {
             MessageBox.Show(this, ex.StackTrace, "Fehler");
+            Logger.Log($"Error while adding wiki file: {ex.Message}", Logger.LogType.Error);
         }
     }
     
@@ -1133,51 +1144,83 @@ public partial class MainWindow : Window
         catch (Exception ex)
         {
             MessageBox.Show(this, ex.StackTrace, "Fehler");
+            Logger.Log($"Error while adding wiki folder: {ex.Message}", Logger.LogType.Error);
         }
     }
 
 
     private async void MnIAdSetRename_OnClick(object? sender, RoutedEventArgs e)
     {
-        if (LstCustomerAdressSets.SelectedItems.Count > 0)
+        var id = (LstCustomerAdressSets.SelectedItems[0] as KasAddressList).ID;
-            try
+        var cus_id = ((Customer)LstCustomers.SelectedItems[0]).ID;
-            {
+        var curr_set = new KasAddressList("");
-                var result = await NamingWindow.Show(this);
-                if (result != null)
-                {
-                    var id = KasAddressList.GetIDByAddressSetListItem(LstCustomerAdressSets.SelectedItems[0]
-                        .ToString());
-                    var cus_id = Customer.GetIDByCustomerListItem(LstCustomers.SelectedItems[0].ToString());
         foreach (var set in Settings._instance.addressSets.addresses)
             if (set.ID == id)
             {
-                            set.Name = result;
+                curr_set = set;
+
+            }
+        
+        
+        if (LstCustomerAdressSets.SelectedItems.Count > 0)
+            try
+            {
+                var result = await NamingWindow.Show(this, curr_set.Name);
+                if (result != null)
+                {
+                    curr_set.Name = result;
                     Settings.Save();
                     RefreshAddressSetListItems(cus_id);
-                            break;
-                        }
                 }
             }
             catch (Exception ex)
             {
                 MessageBox.Show(this, ex.StackTrace, "Fehler");
+                Logger.Log($"Error while renaming address set: {ex.Message}", Logger.LogType.Error);
             }
     }
 
     private void BtnDeleteCustomer_OnClick(object? sender, RoutedEventArgs e)
     {
         if (LstSettingsCustomers.SelectedIndex == null || LstSettingsCustomers.SelectedIndex == -1) return;
-        foreach (var customer in Settings._instance.customers.customers)
-            if (customer.ID == Settings._instance.customers.current)
         try
         {
-                    Settings._instance.customers.customers.Remove(customer);
+            Settings._instance.customers.customers.Remove((Customer)LstSettingsCustomers.SelectedItem);
-                    break;
         }
         catch (Exception ex)
         {
             MessageBox.Show(this, "Unknown Error: " + ex.Message, "Error");
+            Logger.Log($"Error while deleting customer: {ex.Message}", Logger.LogType.Error);
         }
         RefreshCustomerItems();
     }
+
+    private void BtnShorten_OnClick(object? sender, RoutedEventArgs e)
+    {
+        MakeCalcManVisible();
+        if (LstCustomerAdressSets.SelectedIndex == -1)
+        {
+            MessageBox.Show(null, "Bitte zunächst ein Adress-Set auswählen", "Kein Adress-Set ausgewählt");
+            return;
+        }
+
+        StartAddressShortener((KasAddressList)LstCustomerAdressSets.SelectedItem);
+    }
+
+    private void ChangeCSVDivider(object sender, RoutedEventArgs e)
+    {
+        try
+        {
+            string div = (sender as Button).Content as string;
+            if (div == "TAB") div = "\t";
+            if (div == "SPACE") div = " ";
+            TbSettingsCustomerCsvSeparator.Text = div;
+            Settings.Save();
+        }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while changing CSV divider: {ex.Message}", Logger.LogType.Error);
+        }
+         
+    }
 }

NamingWindow.axaml.cs

@@ -52,7 +52,7 @@ public partial class NamingWindow : Window
         }
         catch (Exception ex)
         {
-            Console.WriteLine("Error while showing naming window: " + ex.Message);
+            Logger.Log("Error while showing naming window: " + ex.Message, Logger.LogType.Warning);
             return Task.FromResult<string>(null!);
         }
     }

ProgressWindow.axaml.cs

@@ -16,9 +16,9 @@ public partial class ProgressWindow : Window
         PbProgress.Value = percentage;
     }
 
-    public void AddToLog(string message)
+    public void AddToLog(string message, string percent)
     {
-        TbLog.Text = message;
+        TbLog.Text = message + $"\n{percent}%";
         //ScvLog.ScrollToEnd();
     }
 }

ResultWindow.axaml

@@ -20,7 +20,9 @@
                     Margin="10,10,10,10" />
         </Grid>
         <ScrollViewer Grid.Column="1" HorizontalScrollBarVisibility="Auto" VerticalScrollBarVisibility="Auto">
-            <StackPanel x:Name="StkResults" Orientation="Vertical" Margin="10" />
+            <!-- <TextBlock x:Name="TbResults"></TextBlock> -->
+            <ListBox x:Name="LbResults"></ListBox>
+            <!-- <StackPanel x:Name="StkResults" Orientation="Vertical" Margin="10" /> -->
         </ScrollViewer>
 
     </Grid>

ResultWindow.axaml.cs

@@ -28,12 +28,25 @@ public partial class ResultWindow : Window
 
     private void GenerateView(List<KasPerson> result)
     {
+        try
+        {
+
+
             // Filter to only show persons with errors
             var result_with_errors = result.Where(p => p.PersonError != null).ToList();
             LblResultCount.Content = $"{result_with_errors.Count}/{ur_result.Count} Ergebnisse";
 
-        StkResults.Children.Clear();
+            // TbResults.Text = "";
-        foreach (var person in result_with_errors) StkResults.Children.Add(CreatePersonGrid(person));
+            // foreach (var person in result_with_errors) TbResults.Text += person.PersonError.GetString()+"\n";
+            LbResults.Items.Clear();
+            foreach (var person in result_with_errors) LbResults.Items.Add(person.PersonError.ToString(person));
+            // StkResults.Children.Clear();
+            // foreach (var person in result_with_errors) StkResults.Children.Add(CreatePersonGrid(person));
+        }
+        catch (Exception ex)
+        {
+            Logger.Log("Error while generating result view: " + ex.Message, Logger.LogType.Warning);
+        }
     }
 
     private Grid CreatePersonGrid(KasPerson person)
@@ -101,6 +114,8 @@ public partial class ResultWindow : Window
     }
 
     private void Load(List<KasPerson> result)
+    {
+        try
         {
             var knownErrors = new List<AddressCheck.ErrorTypes>();
             var knownWarnings = new List<AddressCheck.WarningTypes>();
@@ -141,12 +156,20 @@ public partial class ResultWindow : Window
 
             GenerateView(result);
         }
+        catch (Exception ex)
+        {
+            Logger.Log("Error while showing naming window: " + ex.Message, Logger.LogType.Warning);
+        }
+        
+    }
 
     private void BtnUpdateFilter_OnClick(object? sender, RoutedEventArgs e)
     {
     }
 
     private void UpdateFilter()
+    {
+        try
         {
             var temp_result = new List<KasPerson>();
 
@@ -201,8 +224,17 @@ public partial class ResultWindow : Window
 
         LblResultCount.Content = $"{temp_result.Count}/{ur_result.Count} Ergebnisse";
 
-        StkResults.Children.Clear();
+        LbResults.Items.Clear();
-        foreach (var person in temp_result) StkResults.Children.Add(CreatePersonGrid(person));
+        foreach (var person in temp_result) LbResults.Items.Add(person.PersonError.ToString(person));
+        // TbResults.Text = "";
+        // foreach (var person in temp_result) TbResults.Text += person.PersonError.GetString() +"\n";
+        // StkResults.Children.Clear();
+        // foreach (var person in temp_result) StkResults.Children.Add(CreatePersonGrid(person));
+        } catch (Exception ex)
+        {
+            Logger.Log("Error while updating filter: " + ex.Message, Logger.LogType.Warning);
+        }
+        
     }
 
 

Tasks/AddressCheck.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
@@ -37,6 +38,8 @@ public class AddressCheck
     }
 
     public async Task<List<KasPerson>> Perform(int id)
+    {
+        try
         {
             // Find the index of the address set with the given id
             var adset_index = -1;
@@ -237,7 +240,8 @@ public class AddressCheck
                             // Directly set PersonError in the address set
                             var person_index = adset.KasPersons.IndexOf(person);
                             if (person_index >= 0)
-                            Settings._instance.addressSets.addresses[adset_index].KasPersons[person_index].PersonError =
+                                Settings._instance.addressSets.addresses[adset_index].KasPersons[person_index]
+                                        .PersonError =
                                     new KasPersonError((errors, warnings));
                         }
 
@@ -247,7 +251,8 @@ public class AddressCheck
                     await Dispatcher.UIThread.InvokeAsync(() =>
                     {
                         if (hasFaults)
-                        _progress.AddToLog($"Person mit id {person.id} ist fehlerhaft");
+                            _progress.AddToLog($"Person mit id {person.id} ist fehlerhaft",
+                                Convert.ToInt32(percent).ToString());
 
                         _progress.ChangePercentage(percent);
                     });
@@ -260,5 +265,14 @@ public class AddressCheck
             return Settings._instance.addressSets.addresses[adset_index].KasPersons
                 .Where(p => p.PersonError != null)
                 .ToList();
+
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing address check: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return null;
+    }
+
 }

Tasks/AddressCreation.cs

@@ -43,7 +43,8 @@ public static class AddressCreator
     public static string? CreateFinalMarkdownString(int id)
     {
         // Maximum seven lines of information
-
+        try
+        {
             // find the address
                     KasPerson? address = null;
                     var string_address = "";
@@ -197,9 +198,18 @@ public static class AddressCreator
                     if (address_line_count > 1) return string_address;
                     return null;
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while creating markdown string: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return null;
+    }
 
     public static string CreateNameLine(string anredezus, string anrede, string titel, string vorname, string adel,
         string name, string namezus)
+    {
+        try
         {
             if (!string.IsNullOrWhiteSpace(anredezus))
                     return string.Join(" ",
@@ -215,6 +225,14 @@ public static class AddressCreator
                    )
                    + (string.IsNullOrWhiteSpace(namezus) ? "" : $" ({namezus.Trim()})");
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing address name line creation: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return null;
+        
+    }
 
     /// <summary>
     ///     Returns true if a plz (or pplz) is valid
@@ -223,6 +241,8 @@ public static class AddressCreator
     /// <param name="land">country, to check the plz</param>
     /// <returns>true or faslse, depending on result :+1:</returns>
     public static bool CheckPLZ(string plz, string land)
+    {
+        try
         {
             if (string.IsNullOrWhiteSpace(plz)) return false;
             
@@ -249,4 +269,12 @@ public static class AddressCreator
             // For non-German countries, accept any non-empty postal code
             return true;
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing address plz check: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return false;
+        
+    }
 }

Tasks/AddressPatch.cs

@@ -3,6 +3,7 @@ using System.IO;
 using System.Linq;
 using System.Reflection;
 using System.Text;
+using Logof_Client;
 
 public class AddressPatch
 {
@@ -57,6 +58,8 @@ public class AddressPatch
     public bool has_funktionad { get; set; }
 
     public static AddressPatch Import(Uri filename)
+    {
+        try
         {
             var patch = new AddressPatch();
             
@@ -92,9 +95,20 @@ public class AddressPatch
             
                     return patch;
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while importing address patch: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return null;
+
+
+    }
 
 
     public override string ToString()
+    {
+        try
         {
             var properties = GetType().GetProperties(BindingFlags.Public | BindingFlags.Instance);
                     var stringProps = properties.Where(p => p.PropertyType == typeof(string) && p.Name.EndsWith("_is"));
@@ -115,4 +129,12 @@ public class AddressPatch
             
                     return lines.ToString().TrimEnd();
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while parsing: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return "Error while parsing";
+        
+    }
 }

Tasks/AddressRepair.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 
 namespace Logof_Client;
@@ -9,15 +10,16 @@ public class AddressRepair(ProgressWindow progressWindow)
     public KasAddressList Perform(KasAddressList all_addresses,
         List<(int, List<AddressCheck.ErrorTypes>)> failed_addresses)
     {
-        // foreach (var k in all_addresses.KasPersons)
+        try
-        // foreach (var p in failed_addresses)
+        {
-        // {
+            
-        //     if (k.refsid != p.Item1) continue;
+        }
-        //
+        catch (Exception ex)
-        //     if (p.Item1.Contains(AddressCheck.WarningTypes.DoubledRefsid))
+        {
-        //     {
+            Logger.Log($"Error while performing address repair: {ex.Message}", Logger.LogType.Error);
-        //     }
+        }
-        // }
+
+        return null;
 
         return null;
     }

Tasks/AddressShortener.cs

@@ -0,0 +1,84 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using System.Threading.Tasks.Dataflow;
+
+namespace Logof_Client;
+
+public class AddressShortener(ProgressWindow progressWindow)
+{
+    private readonly ProgressWindow _progress = progressWindow;
+
+    public async Task Perform(KasAddressList list)
+    {
+        try
+        {
+            List<int> doubled_ids = new List<int>();
+                    for (int i = 0; i < list.KasPersons.Count; i++)
+                    {
+                        var address =  list.KasPersons[i];
+                        for (int j = 0; j < list.KasPersons.Count; j++)
+                        {
+                            if (i == j) continue;
+                            var sec_address =  list.KasPersons[j];
+                            
+                            if (address.refsid == sec_address.refsid && !doubled_ids.Contains(address.refsid) && address.refsid != 0)
+                            {
+                                doubled_ids.Add(address.refsid);
+                            }
+                        }
+                    }
+                    
+                    
+                    // delete doubled addresses by refsid
+                    foreach (int id in doubled_ids)
+                    {
+                        // does this remove both of the doubled addresses?
+                        list.KasPersons.Remove(list.KasPersons.FirstOrDefault(x => x.refsid == id));
+                    }
+            
+                    List<int> toRemove = new List<int>();
+                    foreach (var address in list.KasPersons)
+                    {
+                        try
+                        {
+                            if (address.PersonError.errors.Contains(AddressCheck.ErrorTypes.NoPLZorPPLZ))
+                            {
+                                toRemove.Add(address.id);
+                            }
+                            else if (address.PersonError.errors.Contains(AddressCheck.ErrorTypes.PlzNotUsable) &&
+                                     address.PersonError.errors.Contains(AddressCheck.ErrorTypes.PPlzNotUsable))
+                            {
+                                toRemove.Add(address.id);
+                            } else if (address.PersonError.errors.Contains(AddressCheck.ErrorTypes.PlzNotUsable) &&
+                                       address.PersonError.warnings.Contains(AddressCheck.WarningTypes.NoPPLZ))
+                            {
+                                toRemove.Add(address.id);
+                            }
+                            else if (address.PersonError.errors.Contains(AddressCheck.ErrorTypes.PPlzNotUsable) &&
+                                     address.PersonError.warnings.Contains(AddressCheck.WarningTypes.NoPLZ))
+                            {
+                                toRemove.Add(address.id);
+                            }
+                        }
+                        catch
+                        {
+                            Console.WriteLine("PersonError not accessible: " + address.id);
+                        }
+                    }
+                    
+                    // delete doubled addresses by refsid
+                    foreach (int id in toRemove)
+                    {
+                        // does this remove both of the doubled addresses?
+                        list.KasPersons.Remove(list.KasPersons.Find(x => x.id == id));
+                    }
+        }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing address shortener: {ex.Message}", Logger.LogType.Error);
+        }
+        
+    }
+}

Tasks/CombineAddresses.cs

@@ -24,14 +24,50 @@ public class CombineAddresses
     }
 
     public async Task<(KasAddressList, KasAddressList)> Perform(List<KasAddressList> address_lists, string type, CombineType comb_type,
+        bool? exportUnused, bool? deleteOld)
+    {
+        try
+        {
+            var result = await Execute(address_lists,type,comb_type,exportUnused);
+            
+                    if (deleteOld == true)
+                    {
+                        foreach (var list in address_lists)
+                        {
+                            Settings._instance.addressSets.addresses.Remove(list);
+                        }
+                    }
+            
+                    return result;
+        }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing address combining: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return (null,null);
+        
+
+    }
+
+    private async Task<(KasAddressList, KasAddressList)> Execute(List<KasAddressList> address_lists, string type, CombineType comb_type,
         bool? exportUnused)
+    {
+        try
         {
             if (type == "difference") return await Difference(address_lists, comb_type, exportUnused);
             if (type == "union") return await Union(address_lists, comb_type, exportUnused);
             if (type == "intersection") return await Intersection(address_lists, comb_type, exportUnused);
             if (type == "symdiff") return await SymmetricDifference(address_lists, comb_type, exportUnused);
+            return (null, null);
+        }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while executing address combining: {ex.Message}", Logger.LogType.Error);
+        }
 
         return (null,null);
+        
     }
 
 
@@ -44,6 +80,7 @@ public class CombineAddresses
     /// <returns></returns>
     public bool CompareAddresses(KasPerson first, KasPerson second, CombineType comb_type)
     {
+        
         // A refsid of 0 means "missing", so it must not collapse unrelated entries.
         if(comb_type == CombineType.refsid)
             if (first.refsid != 0 && second.refsid != 0 && first.refsid == second.refsid) return true;
@@ -79,6 +116,8 @@ public class CombineAddresses
     public async Task<(KasAddressList, KasAddressList)> Difference(List<KasAddressList> address_lists, CombineType comb_type,
         bool? return_unused,
         Progress? progress = null)
+    {
+        try
         {
             if (address_lists == null || address_lists.Count == 0)
                 return (new KasAddressList(await KasAddressList.GenerateName("difference")), null);
@@ -117,10 +156,20 @@ public class CombineAddresses
             if (return_unused == true) return (result, second_result);
             return (result, null);
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing difference-combining: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return (null,null);
+        
+    }
 
 
     public async Task<(KasAddressList, KasAddressList)> Union(List<KasAddressList> address_lists, CombineType comb_type, bool? return_unused,
         Progress progress = null)
+    {
+        try
         {
             var result = new KasAddressList(await KasAddressList.GenerateName("union"));
             var second_result = new KasAddressList("none");
@@ -156,6 +205,14 @@ public class CombineAddresses
             if (return_unused == true) return (result, second_result);
             return (result, null);
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing union-combining: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return (null,null);
+        
+    }
 
 
     public async Task<KasAddressList> MoveDuplicatesToNew()
@@ -165,6 +222,8 @@ public class CombineAddresses
 
     public async Task<(KasAddressList, KasAddressList)> Intersection(List<KasAddressList> address_lists, CombineType comb_type,
         bool? return_unused, Progress progress = null)
+    {
+        try
         {
             var result = new KasAddressList(await KasAddressList.GenerateName("intersection"));
             var second_result = new KasAddressList("none");
@@ -209,10 +268,20 @@ public class CombineAddresses
             if (return_unused == true) return (result, second_result);
             return (result, null);
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing intersection-combining: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return (null,null);
+        
+    }
 
 
     public async Task<(KasAddressList, KasAddressList)> SymmetricDifference(List<KasAddressList> address_lists, CombineType comb_type,
         bool? return_unused, Progress progress = null)
+    {
+        try
         {
             var result = new KasAddressList(await KasAddressList.GenerateName("symmetric_difference"));
             var second_result = new KasAddressList("none");
@@ -268,6 +337,14 @@ public class CombineAddresses
             if (return_unused == true) return (result, second_result);
             return (result, null);
         }
+        catch (Exception ex)
+        {
+            Logger.Log($"Error while performing symdiff-combining: {ex.Message}", Logger.LogType.Error);
+        }
+
+        return (null,null);
+        
+    }
     
 }