[fix:] multiple little fixed for the combining methods
This commit is contained in:
+24
-16
@@ -15,14 +15,21 @@ public class CombineAddresses
|
||||
{
|
||||
_progress = progressWindow;
|
||||
}
|
||||
|
||||
public enum CombineType
|
||||
{
|
||||
refsid,
|
||||
final_adress,
|
||||
none
|
||||
}
|
||||
|
||||
public async Task<(KasAddressList, KasAddressList)> Perform(List<KasAddressList> address_lists, string type,
|
||||
public async Task<(KasAddressList, KasAddressList)> Perform(List<KasAddressList> address_lists, string type, CombineType comb_type,
|
||||
bool? exportUnused)
|
||||
{
|
||||
if (type == "difference") return await Difference(address_lists, exportUnused);
|
||||
if (type == "union") return await Union(address_lists, exportUnused);
|
||||
if (type == "intersection") return await Intersection(address_lists, exportUnused);
|
||||
if (type == "symdiff") return await SymmetricDifference(address_lists, exportUnused);
|
||||
if (type == "difference") return await Difference(address_lists, comb_type, exportUnused);
|
||||
if (type == "union") return await Union(address_lists, comb_type, exportUnused);
|
||||
if (type == "intersection") return await Intersection(address_lists, comb_type, exportUnused);
|
||||
if (type == "symdiff") return await SymmetricDifference(address_lists, comb_type, exportUnused);
|
||||
|
||||
return (null, null);
|
||||
}
|
||||
@@ -35,11 +42,12 @@ public class CombineAddresses
|
||||
/// <param name="second">Second address to compare</param>
|
||||
/// <param name="only_refsid">If true, only a refsid-check will be done</param>
|
||||
/// <returns></returns>
|
||||
public bool CompareAddresses(KasPerson first, KasPerson second, bool only_refsid = false)
|
||||
public bool CompareAddresses(KasPerson first, KasPerson second, CombineType comb_type)
|
||||
{
|
||||
// A refsid of 0 means "missing", so it must not collapse unrelated entries.
|
||||
if (first.refsid != 0 && second.refsid != 0 && first.refsid == second.refsid) return true;
|
||||
if (!only_refsid)
|
||||
if(comb_type == CombineType.refsid)
|
||||
if (first.refsid != 0 && second.refsid != 0 && first.refsid == second.refsid) return true;
|
||||
if (comb_type == CombineType.final_adress)
|
||||
if (first.name == second.name &&
|
||||
first.anrede == second.anrede &&
|
||||
first.anredzus == second.anredzus &&
|
||||
@@ -68,7 +76,7 @@ public class CombineAddresses
|
||||
return false;
|
||||
}
|
||||
|
||||
public async Task<(KasAddressList, KasAddressList)> Difference(List<KasAddressList> address_lists,
|
||||
public async Task<(KasAddressList, KasAddressList)> Difference(List<KasAddressList> address_lists, CombineType comb_type,
|
||||
bool? return_unused,
|
||||
Progress? progress = null)
|
||||
{
|
||||
@@ -92,7 +100,7 @@ public class CombineAddresses
|
||||
|
||||
foreach (var person in address_lists[0].KasPersons)
|
||||
{
|
||||
var isDouble = restUnion.Any(p => CompareAddresses(person, p));
|
||||
var isDouble = restUnion.Any(p => CompareAddresses(person, p, comb_type));
|
||||
if (!isDouble)
|
||||
result.KasPersons.Add(person);
|
||||
else
|
||||
@@ -111,7 +119,7 @@ public class CombineAddresses
|
||||
}
|
||||
|
||||
|
||||
public async Task<(KasAddressList, KasAddressList)> Union(List<KasAddressList> address_lists, bool? return_unused,
|
||||
public async Task<(KasAddressList, KasAddressList)> Union(List<KasAddressList> address_lists, CombineType comb_type, bool? return_unused,
|
||||
Progress progress = null)
|
||||
{
|
||||
var result = new KasAddressList(await KasAddressList.GenerateName("union"));
|
||||
@@ -128,7 +136,7 @@ public class CombineAddresses
|
||||
foreach (var list in address_lists)
|
||||
foreach (var person in list.KasPersons)
|
||||
{
|
||||
if (!result.KasPersons.Any(existing => CompareAddresses(existing, person)))
|
||||
if (!result.KasPersons.Any(existing => CompareAddresses(existing, person, comb_type)))
|
||||
result.KasPersons.Add(person);
|
||||
else
|
||||
second_result.KasPersons.Add(person);
|
||||
@@ -155,7 +163,7 @@ public class CombineAddresses
|
||||
return null;
|
||||
}
|
||||
|
||||
public async Task<(KasAddressList, KasAddressList)> Intersection(List<KasAddressList> address_lists,
|
||||
public async Task<(KasAddressList, KasAddressList)> Intersection(List<KasAddressList> address_lists, CombineType comb_type,
|
||||
bool? return_unused, Progress progress = null)
|
||||
{
|
||||
var result = new KasAddressList(await KasAddressList.GenerateName("intersection"));
|
||||
@@ -176,7 +184,7 @@ public class CombineAddresses
|
||||
{
|
||||
// Prüfen, ob Person in *allen* anderen Listen vorkommt
|
||||
var isInAll = otherLists.All(list =>
|
||||
list.KasPersons.Any(existing => CompareAddresses(existing, person)));
|
||||
list.KasPersons.Any(existing => CompareAddresses(existing, person, comb_type)));
|
||||
|
||||
if (isInAll)
|
||||
result.KasPersons.Add(person);
|
||||
@@ -203,7 +211,7 @@ public class CombineAddresses
|
||||
}
|
||||
|
||||
|
||||
public async Task<(KasAddressList, KasAddressList)> SymmetricDifference(List<KasAddressList> address_lists,
|
||||
public async Task<(KasAddressList, KasAddressList)> SymmetricDifference(List<KasAddressList> address_lists, CombineType comb_type,
|
||||
bool? return_unused, Progress progress = null)
|
||||
{
|
||||
var result = new KasAddressList(await KasAddressList.GenerateName("symmetric_difference"));
|
||||
@@ -223,7 +231,7 @@ public class CombineAddresses
|
||||
foreach (var person in list.KasPersons)
|
||||
{
|
||||
// Prüfen, ob schon vorhanden
|
||||
var existing = allPersons.FirstOrDefault(p => CompareAddresses(p.person, person));
|
||||
var existing = allPersons.FirstOrDefault(p => CompareAddresses(p.person, person, comb_type));
|
||||
if (existing.person != null)
|
||||
{
|
||||
// Falls schon drin → Vorkommen erhöhen
|
||||
|
||||
Reference in New Issue
Block a user